libfm build bug found packaging XStreamOS/illumos distro

[gbulfon]

Hi, I found a very easy bug in configure script, while packaging libfm on our XStreamOS/illumos distro.
The packaging framework take care of separating source directory from build/prototype directories.
When the build directory is different from the source directory, libtools complains not finding libfmactions.la.

The reason, is that inside configure, LIBFMACTIONS var is stated as '$(srcdir)/actions/libfmactions.la'.
In this case, the build directory is elsewhere, and it's containing the libfmactions.la file, not srcdir.

I had to patch configure like this:

Code: Select all

--- libfm-1.1.0/configure       Tue May  7 14:33:58 2013
+++ libfm-1.1.0/configure       Tue May  7 14:34:24 2013
@@ -12602,7 +12602,7 @@
             as_fn_error $? "No Vala compiler found but it is required." "$LINENO" 5
         fi
     fi
-    LIBFMACTIONS='$(srcdir)/actions/libfmactions.la'
+    LIBFMACTIONS='$(top_builddir)/src/actions/libfmactions.la'
     ACTIONS_SUBDIR='actions'

 $as_echo "#define HAVE_ACTIONS 1" >>confdefs.h

Maybe you can include this patch in your source repo.
Bye,
Gabriele.

[Rex Bouwense]

Welcome to the LXDE forum. Thank you for the information although I doubt that the developers will read this. It does provide the users here with the solution patch and instructions for solving it.
See the third annoucement above for further information on reporting.
Stick around and help us if you can.

[gbulfon]

ok, let me know if there is a better place for this to reach developers.

Anyway, I'm almost done packaging LXDE as the default GUI interface for our upcoming illumos based XStreamOS Desktop, featuring ZFS and all the delicious stuff illumos provides in kernel
Thanx!
Gabriele.

[Rex Bouwense]

I guess our posts crossed. In the third announcement above there is a discussion and a couple of sites for reporting bugs and submitting patches. Thank you.

[LStranger]

You should send your bug reports into bug tracker, not into forum.
Mentioned problem is fixed in next version of libfm (1.2) which is planned for beta release later this month.
Thank you very much.